[MPlayer-dev-eng] [PATCH] stream layer support for .ifo files

[Vladimir Voroshilov]

On Dec 17, 2007 1:29 PM, Reimar Döffinger
<Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hello,
> On Mon, Dec 17, 2007 at 08:49:41AM +0800, Ulion wrote:
> [...]
> > http://svn.mplayerhq.hu/mplayer/trunk/stream/stream_dvd.c?view=diff&r1=25237&r2=25238
> >
> > Which breaks mingw compile because the libgen.h and basename/dirname stuff.
>

ah. it does.

> And in addition that usage of basename/dirname is broken anyway since it
> may modify stream->url, that is not acceptable.
> I also have some doubts if the way those functions behave in corner
> cases is really what is desired...
>

well. is implementation something like:

idx=-1;
for(i=0;stream->url[i]; i++)
  if(stream->url[i]=='/')
     idx=i;

if(idx>=0)
{
  filename=strdup(stream->url+idx+1);
  dvd_device=malloc(idx);
  strncpy(dvd_device,stream->url, idx);
}

acceptable or hole patch should be reverted (lossing these feature)?

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719