[MPlayer-dev-eng] [PATCH] stream layer support for .ifo files

Rich Felker dalias at aerifal.cx
Mon Dec 17 08:35:38 CET 2007


On Mon, Dec 17, 2007 at 08:29:01AM +0100, Reimar Döffinger wrote:
> Hello,
> On Mon, Dec 17, 2007 at 08:49:41AM +0800, Ulion wrote:
> [...]
> > http://svn.mplayerhq.hu/mplayer/trunk/stream/stream_dvd.c?view=diff&r1=25237&r2=25238
> > 
> > Which breaks mingw compile because the libgen.h and basename/dirname stuff.
> 
> And in addition that usage of basename/dirname is broken anyway since it
> may modify stream->url, that is not acceptable.
> I also have some doubts if the way those functions behave in corner
> cases is really what is desired...

Indeed, these functions should never be used.

Rich



More information about the MPlayer-dev-eng mailing list