[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

[Ulion]

2007/12/6, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Thu, Dec 06, 2007 at 07:20:54PM +0800, Ulion wrote:
> > With Rich's suggestion, patch updated:
> > 1. Remove access check code change to use access() call.
>
> What is the point of that though? And why not put it in the pipe_open
> function, together with the unrar_executable != NULL check?

I meant use access() instead of stat(). As move them into pipe_open,
I'd like to, but current pipe_open are splited by MINGW macro and some
declaration at beginning of each part of #ifdef. Then that need two
copy of access check code also, so that looks not better than current
implement.

> And you also have a comment saying
> "/* This is the child process.  Execute the shell command. */"
> but there is no shell involved, you execute the file directly via execl...

Oh, that comment comes from old patch code, I fix it. btw: does it
make any sense to run the executable by a shell?

> About the Windows part: You could try using CommandLineToArgvW to make
> sure your escaping did not mess up (and neither does the windows code
> mess up undoing the escaping).

I just checked the API you mentioned, it seems be used parsing whole
command line into argv list, it's not what we needed, if there's such
api match our needs, we should use it. By now, we still can only use
our escape function for that.

-- 
Ulion