[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

[Reimar Döffinger]

Hello,
On Thu, Dec 06, 2007 at 07:20:54PM +0800, Ulion wrote:
> With Rich's suggestion, patch updated:
> 1. Remove access check code change to use access() call.

What is the point of that though? And why not put it in the pipe_open
function, together with the unrar_executable != NULL check?
And you also have a comment saying
"/* This is the child process.  Execute the shell command. */"
but there is no shell involved, you execute the file directly via execl...
About the Windows part: You could try using CommandLineToArgvW to make
sure your escaping did not mess up (and neither does the windows code
mess up undoing the escaping).

Greetings,
Reimar Döffinger