[MPlayer-dev-eng] [PATCH] color SPU with ass (EOSD)

[Ötvös Attila]

2007. december 3. 13.32 dátummal Ulion ezt írta:
Hi Ulion!

> I tested with your patch.
>
> spudec.c:1334: warning: unused variable 'i'

I fixed.

> In second patch, when first happens:
> +    h = FFMIN(bitmap_h,dmpi->h - dst_y);
> +    w = FFMIN(bitmap_w,dmpi->w - dst_x);
> Beginning should be tabs instead of spaces.

I corrected.

> Functions you added parameters dxs, dys, you should document them if
> original functions have comments.

I added.

> And at such like this line-break places:
> +static void ass_eosd_generator(double pts, unsigned int dxs, unsigned int
> dys, +       mp_eosd_images_t* dst, void* data)

I corrected.

> You should make breaked line aligned with the first parameter.
>
> And when continue play more than one videos with -ass, will crash in
> filter_video, that should be fixed.

I fixed (add eosd_unregister() to vf_ass and vf_vo). I hope to work.

Please try out.

Best regard.
Attila
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ass-unregister_and_scaler.patch
Type: text/x-diff
Size: 9143 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071203/37af82a2/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ass-fmt_and_gen-eosd.patch
Type: text/x-diff
Size: 9532 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071203/37af82a2/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: color-spu-with-ass.patch
Type: text/x-diff
Size: 26585 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071203/37af82a2/attachment-0002.patch>