[MPlayer-dev-eng] [PATCH] color SPU with ass (EOSD)

[Ulion]

2007/12/3, Ötvös Attila <oattila at chello.hu>:
> 2007. augusztus 15. 20.05 dátummal Ötvös Attila ezt írta:
> > Hi All!
> >
> > 1. Implemet image render with ass:
> > The ass-fmt_and_gen-eosd.patch is 2in1:
> > gen-eosd.patch, ass-fmt.patch of Evgeniy Stepanov.
> >
> > http://archives.free.net.ph/message/20070811.210648.9e74a56d.en.html
> > http://archives.free.net.ph/message/20070812.132830.c65272d4.en.html
> >
> > Thank you for Evgeniy Stepanov.
> >
> >
> > 2. ass-unregister_and_scaler.pacth
> > I add unregister eosd_generator, check ass image size and
> > add scaler (dxs, dys).
> >
> >
> > 3. My main color SPU patch with ass (EOSD):
> > color-spu-with-ass.patch
> >
> > If ass enabled then MPlayer use ass with color SPU.
> >
> > Best regards.
> > Attila
>
> Hi All!
>
> I corrected eosd_register_number in color-spu-with-ass.patch and I updated
> patchs.
>
> Best regards.
> Attila

I tested with your patch.

spudec.c:1334: warning: unused variable 'i'

In second patch, when first happens:
+    h = FFMIN(bitmap_h,dmpi->h - dst_y);
+    w = FFMIN(bitmap_w,dmpi->w - dst_x);
Beginning should be tabs instead of spaces.

Functions you added parameters dxs, dys, you should document them if
original functions have comments.

And at such like this line-break places:
+static void ass_eosd_generator(double pts, unsigned int dxs, unsigned int dys,
+       mp_eosd_images_t* dst, void* data)

You should make breaked line aligned with the first parameter.

And when continue play more than one videos with -ass, will crash in
filter_video, that should be fixed.

-- 
Ulion