[MPlayer-dev-eng] [PATCH] Optional VIDIX PCI devices name database

[Benjamin Zores]

Diego Biurrun a écrit :
> On Mon, Dec 03, 2007 at 12:42:19PM +0100, Benjamin Zores wrote:
>> On Dec 3, 2007 11:57 AM, Diego Biurrun <diego at biurrun.de> wrote:
>>> On Sun, Dec 02, 2007 at 06:56:20PM +0100, Benjamin Zores wrote:
>>>> Opinions ?
>>>>
>>>> --- vidix/Makefile    (revision 25211)
>>>> +++ vidix/Makefile    (working copy)
>>>> @@ -29,6 +29,12 @@
>>>>  OBJS_MPLAYER += rage128_vid.o
>>>>  endif
>>>>
>>>> +ifeq ($(VIDIX_PCIDB), yes)
>>>> +PCI_DB = 1
>>>> +else
>>>> +PCI_DB = 0
>>>> +endif
>>> This is completely redundant.  Just set PCI_DB directly in configure.
>> One is string, other is integer.
>> I have absolutely no knowledge at all about awk, but does "if(yes)" do
>> the same than "if(1)" ?
> 
> I have no idea about awk, but nothing stops you from setting PCI_DB in
> configure.

Better like this way ?

Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-vidix-nopcidb.diff
Type: text/x-diff
Size: 4698 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071203/2d7e39b4/attachment.diff>