[MPlayer-dev-eng] [PATCH] Optional VIDIX PCI devices name database

Diego Biurrun diego at biurrun.de
Mon Dec 3 13:52:21 CET 2007


On Mon, Dec 03, 2007 at 12:42:19PM +0100, Benjamin Zores wrote:
> On Dec 3, 2007 11:57 AM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Sun, Dec 02, 2007 at 06:56:20PM +0100, Benjamin Zores wrote:
> > >
> > > Opinions ?
> > >
> > > --- vidix/Makefile    (revision 25211)
> > > +++ vidix/Makefile    (working copy)
> > > @@ -29,6 +29,12 @@
> > >  OBJS_MPLAYER += rage128_vid.o
> > >  endif
> > >
> > > +ifeq ($(VIDIX_PCIDB), yes)
> > > +PCI_DB = 1
> > > +else
> > > +PCI_DB = 0
> > > +endif
> >
> > This is completely redundant.  Just set PCI_DB directly in configure.
> 
> One is string, other is integer.
> I have absolutely no knowledge at all about awk, but does "if(yes)" do
> the same than "if(1)" ?

I have no idea about awk, but nothing stops you from setting PCI_DB in
configure.

Diego



More information about the MPlayer-dev-eng mailing list