[MPlayer-dev-eng] [PATCH] Adjust log level from error to warning when auto loading sub fails.

Ulion ulion2002 at gmail.com
Sun Dec 2 17:33:06 CET 2007


2007/12/3, Uoti Urpala <uoti.urpala at pp1.inet.fi>:
> On Sun, 2007-12-02 at 07:35 +0800, Ulion wrote:
> > 2007/12/2, Uoti Urpala <uoti.urpala at pp1.inet.fi>:
> > > On Fri, 2007-11-30 at 13:01 +0800, Ulion wrote:
> > > > +    if (!asst && !subd && silent < 2)
> > >
> > > Does anything use silent >= 2?
> >
> > No, but the parameter named 'silent', it should support 'really
> > silent' like it was if needed.
> > So I keep the feature, does this make sense?
>
> I think it's usually a bad idea to add extra generality/features which
> are currently unused "in case they'll be needed", unless you have a
> clear plan that involves using them soon.

I just don't want to break the original function's feature, If it's
acceptable, I'd like to not support real silent and rename that
parameter to 'noerr', is this acceptable?

-- 
Ulion
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sub_load_warning2.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071203/847fe984/attachment.txt>


More information about the MPlayer-dev-eng mailing list