[MPlayer-dev-eng] [PATCH] Adjust log level from error to warning when auto loading sub fails.

Uoti Urpala uoti.urpala at pp1.inet.fi
Sun Dec 2 17:10:44 CET 2007


On Sun, 2007-12-02 at 07:35 +0800, Ulion wrote:
> 2007/12/2, Uoti Urpala <uoti.urpala at pp1.inet.fi>:
> > On Fri, 2007-11-30 at 13:01 +0800, Ulion wrote:
> > > +    if (!asst && !subd && silent < 2)
> >
> > Does anything use silent >= 2?
> 
> No, but the parameter named 'silent', it should support 'really
> silent' like it was if needed.
> So I keep the feature, does this make sense?

I think it's usually a bad idea to add extra generality/features which
are currently unused "in case they'll be needed", unless you have a
clear plan that involves using them soon.




More information about the MPlayer-dev-eng mailing list