[MPlayer-dev-eng] [PATCH] tvi_bsdbt848.c cleanup: perror -> mp_msg

[Vladimir Voroshilov]

2007/8/26, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sun, Aug 26, 2007 at 04:10:53PM +0700, Vladimir Voroshilov wrote:
> > 2007/8/26, Bernd Ernesti <mplayer-dev-eng at lists.veego.de>:
> > > On Sun, Aug 26, 2007 at 10:13:42AM +0200, Reimar Döffinger wrote:
> > > > Hello,
> > > > On Sun, Aug 26, 2007 at 01:50:18AM +0700, Vladimir Voroshilov wrote:
> > > > > Attached patch replaces all occurances of perror(...) to
> > > > > mp_msg(MSGT_TV,MSGL_ERR,...).
> > > > >
> > > > > BSD guys, please make compilation test.
> > > >
> > > > That makes the message much less helpful, I think you should append
> > > > strerror(errno);
> > >
> > > That and changing the lines from
> > >  mp_msg(MSGT_TV,MSGL_ERR,"tvi_bsdbt848:
> > > to
> > >  mp_msg(MSGT_TV, MSGL_ERR, "%s:
> > > too.
> > >
> >
> > Like in attched patch ?
>
> Well, I find that "%s: " incredibly stupid, but it is already done in
> other places, so feel free to do it however you like.
>

Is this version better ?

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bt848_perror_mp_msg2.diff
Type: application/octet-stream
Size: 9822 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070826/57d84a44/attachment.obj>