[MPlayer-dev-eng] [PATCH] tvi_bsdbt848.c cleanup: perror -> mp_msg

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Aug 26 17:52:55 CEST 2007


Hello,
On Sun, Aug 26, 2007 at 06:54:26PM +0700, Vladimir Voroshilov wrote:
> 2007/8/26, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
[...]
> > Well, I find that "%s: " incredibly stupid, but it is already done in
> > other places, so feel free to do it however you like.
> >
> 
> Is this version better ?

Looks good to me, though the errno number itself is a rather useless
information, you can expect strerror to have correct messages for all
valid values.
I think Bernd would have prefered it if you added a space after each ','
in the function calls, but I haven't checked if that matches the style
of the file.
IMO feel free to apply anytime.

Greetings,
Reimar Doeffinger



More information about the MPlayer-dev-eng mailing list