[MPlayer-dev-eng] [PATCH] double click support on Mac OSX

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Aug 18 12:40:19 CEST 2007


Hello,
On Sat, Aug 18, 2007 at 04:16:59PM +0800, Ulion wrote:
> 2007/8/18, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > If it works (could not even test compilation), attached patch might be a
> > better way for 1. + 2.
> >
> It seems I sent a similar patch with your one, most part of code is same.
> 
> as the difference, I think the "other mouse events" should take us
> more mouse buttons, why not fix the code to support up to 10 mouse
> buttons instead of the only first three of them?

Of course, especially since it simplifies the code. But it has nothing
to do with making double-click work, so it definitely should not be in
the same patch (see point 8 of DOCS/tech/patches.txt).
Now what I need first of all is either an okay for a specific patch or a
general go-ahead for something similar to this from our maintainer for
this code, so I CC him...

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list