[MPlayer-dev-eng] [PATCH] double click support on Mac OSX

[Ulion]

2007/8/18, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sat, Aug 18, 2007 at 08:09:36AM +0200, Reimar D?ffinger wrote:
> > On Sat, Aug 18, 2007 at 11:56:05AM +0800, Ulion wrote:
> > > I found vo driver on mac osx does not send all necessary mouse events,
> > > that caused lack of support for double click events, here's the patch.
> > >
> > > 1. send mouse down events correctly so mplayer can detect double click
> > > correctly.
> > > 2. send mouse up events, to release corresponding mouse down events.
> > > 3. detect up to 10 buttons up and down events.
> >
> > Ideally separate things should be done in separate patches (esp. the
> > purely cosmetic renaming of the MouseEvent function into
> > MouseDownEvent - couldn't you just add a parameter that decides between
> > up and down?).
> > But more importantly, you should use
> > MOUSE_BTN0 + ...
> > instead of
> > MOUSE_BASE + ...
>
> If it works (could not even test compilation), attached patch might be a
> better way for 1. + 2.
>
> Greetings,
> Reimar Döffinger
>
It seems I sent a similar patch with your one, most part of code is same.

as the difference, I think the "other mouse events" should take us
more mouse buttons, why not fix the code to support up to 10 mouse
buttons instead of the only first three of them?


-- 
Ulion