[MPlayer-dev-eng] [PATCH] Apple Remote support

Ulion ulion2002 at gmail.com
Mon Aug 13 11:13:50 CEST 2007


2007/8/13, Diego Biurrun <diego at biurrun.de>:
>
> Again, please try to keep lines below 80 characters, it makes things
> more readable.  Especially for multiline comments it makes no sense.
> This applies everywhere.
adjusted except few lines that limit will break a single expression.

>
> > --- input/ar.h        (revision 0)
> > +++ input/ar.h        (revision 0)
> > @@ -0,0 +1,43 @@
> > +
> > +#ifndef INPUT_AR_H_
> > +#define INPUT_AR_H_
> > +
> > +#endif /* INPUT_AR_H */
>
> This is inconsistent, drop the underscore at the end.
fixed.

>
> > --- etc/input.conf    (revision 24050)
> > +++ etc/input.conf    (working copy)
> > @@ -100,6 +100,21 @@
> >
> > +AR_VUP volume 1
> > +AP_VDOWN volume -1
>
> I assume it should be AR_ and not AP_ here..
>
> Diego
fixed.

fixed patch is here

-- 
Ulion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: apple_remote_grammer_fixed2.patch
Type: application/octet-stream
Size: 28596 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070813/777945a7/attachment.obj>


More information about the MPlayer-dev-eng mailing list