[MPlayer-dev-eng] [PATCH] use $_exesuf in configure for tmp files that might get executed

Diego Biurrun diego at biurrun.de
Fri Aug 3 18:51:55 CEST 2007


On Thu, Aug 02, 2007 at 11:11:07AM +0200, Reimar Döffinger wrote:
> IMO it would be more correct to do it like this and also helps porting
> to OSs that rely a bit too much on file extensions.
> 
> --- configure	(revision 23992)
> +++ configure	(working copy)
> @@ -1278,10 +1278,6 @@
>  
>  TMPLOG="configure.log"
>  rm -f "$TMPLOG"
> -TMPC="$I/mplayer-conf-$RANDOM-$$.c"
> -TMPCPP="$I/mplayer-conf-$RANDOM-$$.cpp"
> -TMPO="$I/mplayer-conf-$RANDOM-$$.o"
> -TMPS="$I/mplayer-conf-$RANDOM-$$.S"
>  
> @@ -1347,7 +1343,12 @@
>  
> +TMPC="$I/mplayer-conf-$RANDOM-$$.c"
> +TMPCPP="$I/mplayer-conf-$RANDOM-$$.cpp"
> +TMPO="$I/mplayer-conf-$RANDOM-$$$_exesuf"
> +TMPS="$I/mplayer-conf-$RANDOM-$$.S"

Hmmm, I'm not sure I like this, at a quick glance it's only ever used to
create object files, not executables.

> @@ -1518,8 +1520,8 @@
>  elif x86; then
>    # all other OSes try to extract CPU information from a small helper
>    # program cpuinfo instead
> -  $_cc -o cpuinfo cpuinfo.c
> -  _cpuinfo="./cpuinfo"
> +  $_cc -o cpuinfo$_exesuf cpuinfo.c
> +  _cpuinfo="./cpuinfo$_exesuf"
>  fi

This is a bug fix that you should commit right away.

Diego



More information about the MPlayer-dev-eng mailing list