[MPlayer-dev-eng] [PATCH] use $_exesuf in configure for tmp files that might get executed

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Fri Aug 3 18:59:46 CEST 2007


Hello,
On Fri, Aug 03, 2007 at 06:51:55PM +0200, Diego Biurrun wrote:
> On Thu, Aug 02, 2007 at 11:11:07AM +0200, Reimar Döffinger wrote:
> > IMO it would be more correct to do it like this and also helps porting
> > to OSs that rely a bit too much on file extensions.
> > 
> > --- configure	(revision 23992)
> > +++ configure	(working copy)
> > @@ -1278,10 +1278,6 @@
> >  
> >  TMPLOG="configure.log"
> >  rm -f "$TMPLOG"
> > -TMPC="$I/mplayer-conf-$RANDOM-$$.c"
> > -TMPCPP="$I/mplayer-conf-$RANDOM-$$.cpp"
> > -TMPO="$I/mplayer-conf-$RANDOM-$$.o"
> > -TMPS="$I/mplayer-conf-$RANDOM-$$.S"
> >  
> > @@ -1347,7 +1343,12 @@
> >  
> > +TMPC="$I/mplayer-conf-$RANDOM-$$.c"
> > +TMPCPP="$I/mplayer-conf-$RANDOM-$$.cpp"
> > +TMPO="$I/mplayer-conf-$RANDOM-$$$_exesuf"
> > +TMPS="$I/mplayer-conf-$RANDOM-$$.S"
> 
> Hmmm, I'm not sure I like this, at a quick glance it's only ever used to
> create object files, not executables.

No. cc_check always creates executables, otherwise we couldn't check
linking and all the -l stuff would be pointless.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list