[MPlayer-dev-eng] [PATCH] Adding frame count to time stamps in OSD

Rich Felker dalias at aerifal.cx
Fri Apr 13 22:16:31 CEST 2007

On Fri, Apr 13, 2007 at 09:13:02PM +0200, Christian Aistleitner wrote:
> Hello,
> On Fri, 13 Apr 2007 20:33:40 +0200, Uoti Urpala <uoti.urpala at pp1.inet.fi>  
> wrote:
> >sh_video->fps isn't necessarily reliable (and certainly isn't for
> >variable frame rate videos). Even in the case where frame rate is
> >constant how would this be any better than showing the current pts with
> >more decimals?
> I used frame count over showing more decimals simple because time codes  
> are typically displayed with frame counts and not with more decimals.

Well this is dumb. MPlayer should not follow suit but instead do it
correctly, which means using pts.

> 1. Build a robust solution (showing wore decimals) not meeting users  
> expectations.

Users should change their expectations. It's not our job to copy
windows crap. Of course using decimals is broken too. We should show
exact pts in the timebase, which would satisfy users (equal to frame
count) of videos with fixed framerate == 1/timebase.

I think what you're describing is showing a timestamp in the timebase
anyway. Just don't call it a framecount. Call it a timebase tick count
or something.


More information about the MPlayer-dev-eng mailing list