[MPlayer-dev-eng] [PATCH] Adding frame count to time stamps in OSD

[Christian Aistleitner]

Hello,

On Fri, 13 Apr 2007 20:33:40 +0200, Uoti Urpala <uoti.urpala at pp1.inet.fi>  
wrote:

> sh_video->fps isn't necessarily reliable (and certainly isn't for
> variable frame rate videos). Even in the case where frame rate is
> constant how would this be any better than showing the current pts with
> more decimals?

I used frame count over showing more decimals simple because time codes  
are typically displayed with frame counts and not with more decimals.
However I completely agree, that variable fps break my implementation of  
frame count. I assume its quite some work to get a frame counter working  
reasonably well with variable fps.
There are two sides:
1. Build a robust solution (showing wore decimals) not meeting users  
expectations.
2. Build a solution that might not work for all cases, but does not harm  
if it does not work. Furthermore, this solution meets the expectations of  
users (at least to those to which I gave the patch).

Per default, showing frame counts is turned off.
A typical mplayer user will not see the frame counter.
YMMV, but those who want to see them are probably more accustomed to the  
frame notation (hh:mm:ss.frame).

Kind regards,
Christian