[MPlayer-dev-eng] [PATCH] Remove ugly #include from tvi_bsdbt848.c

[Diego Biurrun]

On Mon, Apr 09, 2007 at 07:08:00PM +0700, Vladimir Voroshilov wrote:
> 2007/4/9, Diego Biurrun <diego at biurrun.de>:
> >On Mon, Apr 09, 2007 at 06:42:55PM +0700, Vladimir Voroshilov wrote:
> >> 2007/4/9, Diego Biurrun <diego at biurrun.de>:
> >> >On Mon, Apr 09, 2007 at 12:53:01AM +0700, Vladimir Voroshilov wrote:
> >> >> Hm. forgot to attach file.
> >> >>
> >> >> --- configure (revision 22945)
> >> >> +++ configure (working copy)
> >> >> @@ -6674,20 +6674,80 @@
> >> >>
> >> >> -if bsd; then
> >> >
> >> >The test was under this check for a reason, why did you remove it?  IMO
> >> >it should go around the header checks as well.
> >>
> >> With this check _tv_bsdbt848 variable will (as did before) have value
> >> "auto". IMO this is not good. In my patch this variable will get
> >> either "yes"'  or "no" value (under another os checks will just fail,
> >> _tv_bsdbt848 will get "no" value).  So i suggest to drop "if bsd" out.
> >
> >That's harmless.  With your patch the tests are run even on non-BSD
> >systems where they are completely useless.  Keep the check.
> >
> Done. What about attached version ?

Commit.

Diego