[MPlayer-dev-eng] [PATCH] Remove ugly #include from tvi_bsdbt848.c

[Vladimir Voroshilov]

2007/4/9, Diego Biurrun <diego at biurrun.de>:
> On Mon, Apr 09, 2007 at 06:42:55PM +0700, Vladimir Voroshilov wrote:
> > 2007/4/9, Diego Biurrun <diego at biurrun.de>:
> > >On Mon, Apr 09, 2007 at 12:53:01AM +0700, Vladimir Voroshilov wrote:
> > >> Hm. forgot to attach file.
> > >>
> > >> --- configure (revision 22945)
> > >> +++ configure (working copy)
> > >> @@ -6674,20 +6674,80 @@
> > >>
> > >> -if bsd; then
> > >
> > >The test was under this check for a reason, why did you remove it?  IMO
> > >it should go around the header checks as well.
> >
> > With this check _tv_bsdbt848 variable will (as did before) have value
> > "auto". IMO this is not good. In my patch this variable will get
> > either "yes"'  or "no" value (under another os checks will just fail,
> > _tv_bsdbt848 will get "no" value).  So i suggest to drop "if bsd" out.
>
> That's harmless.  With your patch the tests are run even on non-BSD
> systems where they are completely useless.  Keep the check.
>
Done. What about attached version ?


-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bsd_ugly_hdr4.diff
Type: application/octet-stream
Size: 3899 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070409/de926d0f/attachment.obj>