[MPlayer-dev-eng] liba52 reorganization

Diego Biurrun diego at biurrun.de
Sat Sep 23 12:34:48 CEST 2006


On Fri, Sep 22, 2006 at 04:26:05PM -0700, Alex Izvorski wrote:
> On Fri, 2006-09-22 at 23:16 +0200, Diego Biurrun wrote:
> 
> > What makes me wonder is the following: Since MPlayer contains liba52
> > plus lots of patches, why not simply try to split our local diff into
> > manageable pieces and feed them upstream bit by bit?
> 
> That is essentially what I'm aiming at.  However, the I think the local
> diff needs to be reorganized too, at a minimum by moving optimized
> versions into separate files, one per (similar to libmpeg2, actually).
> The rest of what I've done is putting function pointers in a52_state
> instead of making them global, avoiding the duplication (triplication)
> of a52_downmix, and consistent naming.

Send  small and self-contained patches for each of these issues, they
are likely to get applied if this helps merging our changes upstream.

Diego



More information about the MPlayer-dev-eng mailing list