[MPlayer-dev-eng] Add demux_nut to libmpdemux

[Diego Biurrun]

On Fri, Sep 15, 2006 at 04:21:55PM +0300, Oded Shimon wrote:
> On Fri, Sep 15, 2006 at 03:16:02PM +0200, Diego Biurrun wrote:
> > On Fri, Sep 15, 2006 at 01:49:17PM +0300, Oded Shimon wrote:
> > > Since libnut doesn't really have any installation method, I have nothing 
> > > to add to MPlayer's configure.
> > 
> > So how do you wish to enable this?
> 
> Basically I just wanted to move 'mplayer.diff' and 'demux_nut.c' out of 
> nut repo, they do not belong there...

I'm fine with adding libnut support, but it should be clean.

> > > --- Makefile	(revision 19814)
> > > +++ Makefile	(working copy)
> > > @@ -110,6 +110,7 @@
> > >               $(X264_LIB) \
> > >               $(MUSEPACK_LIB) \
> > >               $(SPEEX_LIB) \
> > > +             $(NUT_LIB) \
> > 
> > useless clutter
> 
> uhh... -lnut is necessary. If I had written a configure part, it would 
> have done 'NUT_LIB=-lnut'.. Obviously now this is redundant, but it's a 
> placeholder...

Then pass --with-extralibs, but don't clutter the Makefile needlessly.

> > Below is a collection of long lines from demux_nut.c, I'd appreciate if
> > you could make them look non-ugly on 80 char terminals.  This makes me
> > think that 8 character indentation is excessive...
> 
> Good thing you're not in charge of NUT repo :) many lines there are ~150 
> chars long...

Ugh, are you trying to compete with the Gui/ subdirectory?

> Like I said, I just wanted to move out demux_nut.c from NUT repo, it's not 
> exactly production ready.. Though it does work :)

Well, when is it going to be finally production ready then.  If you
don't intend to finish it, how serious are you about NUT?

Seriously, NUT is supposedly frozen, but libnut does not even have an
installation routine?  I don't know if I should laugh or cry ...

Diego