[MPlayer-dev-eng] Add demux_nut to libmpdemux

[Oded Shimon]

On Fri, Sep 15, 2006 at 03:48:37PM +0200, Diego Biurrun wrote:
> On Fri, Sep 15, 2006 at 04:21:55PM +0300, Oded Shimon wrote:
> > uhh... -lnut is necessary. If I had written a configure part, it would 
> > have done 'NUT_LIB=-lnut'.. Obviously now this is redundant, but it's a 
> > placeholder...
> 
> Then pass --with-extralibs, but don't clutter the Makefile needlessly.

uhh, isn't this the standard way of using libraries for modules? I 
honestly don't know, I'm asking.

> > > Below is a collection of long lines from demux_nut.c, I'd appreciate if
> > > you could make them look non-ugly on 80 char terminals.  This makes me
> > > think that 8 character indentation is excessive...
> > 
> > Good thing you're not in charge of NUT repo :) many lines there are ~150 
> > chars long...
> 
> Ugh, are you trying to compete with the Gui/ subdirectory?

My console is 160 chars, naturally my code lines end up same width...

> > Like I said, I just wanted to move out demux_nut.c from NUT repo, it's not 
> > exactly production ready.. Though it does work :)
> 
> Well, when is it going to be finally production ready then.  If you
> don't intend to finish it, how serious are you about NUT?

I underestimated demux_nut.c ... It's pretty good quality now that I 
re-checked it, at very least better than some/most parts of MPlayer... 
Only a few very minor FIXME's in the code, mostly related to displaying 
the current time position in the file...

> Seriously, NUT is supposedly frozen, but libnut does not even have an
> installation routine?  I don't know if I should laugh or cry ...

"libnut" is a grand total of 2 source files and 2 header files.., I 
consider even the Makefile redundant, let alone an installation routine...

BTW, I haven't done any hacking on NUT since the spec was frozen, so I'm 
still in the "pre-release" era :)

- ods15