[MPlayer-dev-eng] [PATCH] ASS - detect changes to speed up -vo gl

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Oct 29 09:42:47 CET 2006


Hello,
On Sat, Oct 28, 2006 at 08:45:47PM +0200, Jindrich Makovicka wrote:
> +  ass_image_t *img = imgs->root;
>    ass_image_t *i;
>    int cnt;
> +
> +  if (!imgs || imgs->changed == 0)
> +      return;
> +

Checking for imgs == NULL after dereferencing makes no sense. Probably
you could simply do without the check.
Also, I'd prefer !imgs->changed instead of imgs->changed == 0.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list