[MPlayer-dev-eng] unneded? hack on vd_raw makes rgb16 fail [PATCH]

[Reimar Döffinger]

Hello,
On Sun, Oct 22, 2006 at 12:00:11PM -0300, Reynaldo H. Verdejo Pinochet wrote:
> On Sun, Oct 22, 2006 at 10:54:57AM +0200, Reimar Döffinger wrote:
> > unfortunate as it maybe, as each pixel allocates 16 bits of memory.
> > Otherwise IMGFMT_BGR32 would have to be 24 bpp, and the right solution
> > is to set sh->format in demux_lavf.c
> 
> Youre right, you told me this before, just that i kept seen this as a
> hack overcome, thinking about it twice, it may be the only way.

I somewhat agree, but after reading the code I decided that I
consider the real hack the workaround for the case biCompression == 0,
not the check for sh->format, and thus proposed a patch to avoid
biCompression == 0.

Greetings,
Reimar Döffinger