[MPlayer-dev-eng] unneded? hack on vd_raw makes rgb16 fail [PATCH]

[Reynaldo H. Verdejo Pinochet]

Hi Reimar

On Sun, Oct 22, 2006 at 10:54:57AM +0200, Reimar Döffinger wrote:
> Hello,
> On Sun, Oct 22, 2006 at 03:53:16AM -0300, Reynaldo H. Verdejo Pinochet wrote:
> > Im here proposing the idea of simply remove this hack, patch attached
> > , id happily (not really true) work on a cleaner fix ON THE AVI DEMUXER
> > if this turns out to be needed for some (weird) sample out there and
> > if and once someone provide such material.
> > 
> > going to commit unless someone has good reasons to do otherwise and
> > a sample thats worth the ugly hack herein discussed.
> 
> I repeat again what I said on IRC: IMGFMT_BGR15 actually is 16 bpp,

So is IMGFMT_BGR16 but we still do colordepth selection using the bpp
value when no codec_tag/codec_id, it may be there where the problem
lays.

> unfortunate as it maybe, as each pixel allocates 16 bits of memory.
> Otherwise IMGFMT_BGR32 would have to be 24 bpp, and the right solution
> is to set sh->format in demux_lavf.c

Youre right, you told me this before, just that i kept seen this as a
hack overcome, thinking about it twice, it may be the only way.


	Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061022/7493d25f/attachment.pgp>