[MPlayer-dev-eng] libdha vs PIC

[Rich Felker]

On Mon, Oct 16, 2006 at 10:13:05AM +0200, Diego Biurrun wrote:
> On Sun, Oct 15, 2006 at 06:46:07PM +0200, Diego Biurrun wrote:
> > On Sun, Oct 15, 2006 at 05:46:22PM +0200, Diego Biurrun wrote:
> > > I'm checking a few Debian issues, the most important is lintian - the
> > > Debian package check program - complaining that lidha contains non-PIC
> > > code:
> > > 
> > > E: mplayer: shlib-with-non-pic-code usr/lib/libdha.so.1.0
> > > 
> > > However, -fPIC is part of the CFLAGS of libdha when creating object
> > > files already ..  If I add -fPIC to the shared library building step
> > > nothing changes and commenting out all assembler references from the
> > > code does not help either.
> > 
> > OK, I was just being blind as a mole, OPTFLAGS contains -fno-PIC, which
> > overrides -fPIC.
> > 
> > I'm not sure what the desired behavior is here.  Should libdha be
> > compiled with PIC or not?  What about shared libraries in general?
> 
> If nobody objects I will just move -fPIC to the end of the CFLAGS line
> in libdha/Makefile so that libdha is always compiled with PIC.

You'd better make it optional (detected by configure) if you're going
to force PIC anywhere. -fPIC will result in compile errors on my
system which does not support PIC, I think...

Rich