[MPlayer-dev-eng] [PATCH] multiple patches from NetBSD pkgsrc

Sergey Svishchev svs+mplayer at grep.ru
Wed Oct 11 22:18:26 CEST 2006


On Wed, Oct 11, 2006 at 10:16:43AM +0200, Diego Biurrun wrote:

>Thanks for the patches.  It would be better to send them separately,
>though as now it becomes hard to track which ones have been applied and
>which have not..

OK, will post 1 patch per message in future...

>> date: 2005/10/24 19:46:05;  author: minskim;  state: Exp;
>> Call isspace(3) with unsigned char, instead of char, to handle
>> non-ASCII characters properly.  Based on patches provided by Kevin Kim
>> 
>> --- subreader.c	(revision 20147)
>> +++ subreader.c	(working copy)
>> @@ -74,10 +74,10 @@
>>  /* Remove leading and trailing space */
>>  static void trail_space(char *s) {
>>  	int i = 0;
>> -	while (isspace(s[i])) ++i;
>> +	while (isspace((unsigned char)s[i])) ++i;
>
>Are these ugly casts really necessary?

I'll ask the person who committed this.

-- 
Sergey Svishchev



More information about the MPlayer-dev-eng mailing list