[MPlayer-dev-eng] [PATCH] multiple patches from NetBSD pkgsrc

[Diego Biurrun]

On Wed, Oct 11, 2006 at 12:34:48AM +0400, Sergey Svishchev wrote:
> 
> I'm forwarding patches from NetBSD pkgsrc; their descriptions are taken 
> directly from
> cvs commit logs.

Thanks for the patches.  It would be better to send them separately,
though as now it becomes hard to track which ones have been applied and
which have not..

> date: 2006/08/04 21:01:21;  author: wiz;  state: Exp;  lines: +16 -7
> Recognize cpu type on x86_64. Patch from Rhialto in PR 33946.
> Original PR:
> http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=33946
> 
> date: 2006/10/03 14:32:24;  author: tron;  state: Exp;  lines: +30 -3
> Fix a few broken "test ... ==" checks in the configure script found
> by "check-portability.mk".

I applied both of these hunks.

> date: 2005/10/24 19:46:05;  author: minskim;  state: Exp;
> Call isspace(3) with unsigned char, instead of char, to handle
> non-ASCII characters properly.  Based on patches provided by Kevin Kim
> 
> --- subreader.c	(revision 20147)
> +++ subreader.c	(working copy)
> @@ -74,10 +74,10 @@
>  /* Remove leading and trailing space */
>  static void trail_space(char *s) {
>  	int i = 0;
> -	while (isspace(s[i])) ++i;
> +	while (isspace((unsigned char)s[i])) ++i;

Are these ugly casts really necessary?

Diego