[MPlayer-dev-eng] [PATCH] remove alloc casts from demux_mkv.c

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Oct 9 20:00:57 CEST 2006


Hello,
On Sun, Oct 08, 2006 at 10:30:40PM +0200, Aurelien Jacobs wrote:
> On Sun, 8 Oct 2006 11:28:56 +0200
> Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
[..]

malloc cast patch applied.

> > I'd also like to ask permission to do some further changes without
> > sending a patch first, like replacing malloc+memset by calloc and
> 
> I don't like calloc very much, but I don't know why (probably not
> for a good reason, so don't care about me).

Since calloc is already used in demux_mkv (though it admittedly avoids a 
multiplication there) I decided to actually go ahead and not care about you :-P

> > adding lot of forgotten frees on error conditions (like in
> > demux_mkv_read_trackentry there are lots of return 0 where track is not
> > freed).
> 
> That would be welcome.

Now for the more difficult part *g*

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list