[MPlayer-dev-eng] [PATCH] remove alloc casts from demux_mkv.c

Aurelien Jacobs aurel at gnuage.org
Sun Oct 8 22:30:40 CEST 2006


On Sun, 8 Oct 2006 11:28:56 +0200
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Hello,
> attached patch does $subj, okay to apply?

I wonder what I was thinking about when I put all those cast...
Sure it's ok to apply.

> I'd also like to ask permission to do some further changes without
> sending a patch first, like replacing malloc+memset by calloc and

I don't like calloc very much, but I don't know why (probably not
for a good reason, so don't care about me).

> adding lot of forgotten frees on error conditions (like in
> demux_mkv_read_trackentry there are lots of return 0 where track is not
> freed).

That would be welcome.
IMO, you can apply your patches on mkv without sending them first.

Aurel



More information about the MPlayer-dev-eng mailing list