[MPlayer-dev-eng] [PATCH] Filename double-conversion

Bernd Ernesti mplayer-dev-eng at lists.veego.de
Wed Nov 15 18:34:46 CET 2006


On Sun, Nov 12, 2006 at 11:43:21AM +0100, Reimar Döffinger wrote:
> Hello,
> On Sun, Nov 12, 2006 at 12:56:00PM +0800, Zuxy Meng wrote:
> > Reimar & Rich, still no comments for the modified version?
> 
> Don't see any problems with it, though it seems not important to me
> either.
> If someone has some spare time, test and feel free to apply.

It doesn't compile on NetBSD:

mp_msg.c: In function `filename_recode':
mp_msg.c:47: error: `MAX_PATH' undeclared (first use in this function)
mp_msg.c:47: error: (Each undeclared identifier is reported only once
mp_msg.c:47: error: for each function it appears in.)
mp_msg.c: In function `mp_msg':
mp_msg.c:126: warning: passing arg 2 of `iconv' from incompatible pointer type
mp_msg.c: In function `filename_recode':
mp_msg.c:47: error: storage size of `recoded_filename' isn't known

It seems that MAX_PATH is a windows thing.

I changed it to PATH_MAX and included sys/param.h and now it compiled.
Where I see no runtime difference when I play a file with a japanese
filename.

Bernd




More information about the MPlayer-dev-eng mailing list