[MPlayer-dev-eng] [PATCH] Make disabling DPMS optional

Holger Weiss holger at CIS.FU-Berlin.DE
Tue Nov 14 18:10:46 CET 2006


* Holger Weiss <holger at CIS.FU-Berlin.DE> [2006-11-05 01:49]:
> * Paul TT <paultt at hackerjournal.it> [2006-11-03 20:09]:
> > Holger Weiss <holger at CIS.FU-Berlin.DE> wrote:
> > > * RC <rcooley at spamcop.net> [2006-11-03 03:22]:
> > > > In any case, I'd certainly pick better option names...  Perhaps
> > > > -(no)dpms ?
> > >
> > > I thought about "-(no)dpms" myself, but found it a bit ambiguous: Does
> > > "-nodpms" mean "disable DPMS" or "don't disable DPMS"?  If you tell me
> > > which way round to do it, I'll send an updated pacth :-)
> >
> > i read it this way:
> > no dpms to me means something like 'don't take care of dpms', so don't
> > disable.
>
> Okay, I've attached a version of the patch which provides "-(no)dpms"
> instead of "-(no)disable-dpms".

Are there any further issues with this patch?

Holger

-- 
PGP fingerprint:  F1F0 9071 8084 A426 DD59  9839 59D3 F3A1 B8B5 D3DE



More information about the MPlayer-dev-eng mailing list