[MPlayer-dev-eng] [PATCH] do not ignore w and h from mpcodecs_config_vo

Reimar D?ffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Nov 2 17:25:20 CET 2006


Hello,
attached patch does $subj, which is needed to play back the second part
of http://samples.mplayerhq.hu/MPEG2/res_change_ffmpeg_aspect.ts
(currently part of the next line is shown at the right border).
Alternatively, the codec could change sh->disp_w and sh->disp_h, but
it seems to make more sense like this.
Do you think this will break something? Why wasn't it does like that
from the start? And finally, okay to apply?

Greetings,
Reimar Döffinger
-------------- next part --------------
Index: libmpcodecs/vd.c
===================================================================
--- libmpcodecs/vd.c	(revision 20606)
+++ libmpcodecs/vd.c	(working copy)
@@ -140,13 +140,9 @@
     int palette=0;
     int vocfg_flags=0;
 
-    if(!sh->disp_w || !sh->disp_h)
-        mp_msg(MSGT_DECVIDEO,MSGL_WARN, MSGTR_CodecDidNotSet);
-    /* XXX: HACK, if sh->disp_* aren't set,
-     * but we have w and h, set them :: atmos */
-    if(!sh->disp_w && w)
+    if(w)
         sh->disp_w=w;
-    if(!sh->disp_h && h)
+    if(h)
         sh->disp_h=h;
 
     if(!sh->disp_w || !sh->disp_h)


More information about the MPlayer-dev-eng mailing list