[MPlayer-dev-eng] [PATCH] fix configure with --enable-x264

[Diego Biurrun]

On Wed, Nov 08, 2006 at 06:05:30PM -0500, Rich Felker wrote:
> On Wed, Nov 08, 2006 at 06:04:31PM +0100, Diego Biurrun wrote:
> > On Wed, Nov 08, 2006 at 07:47:14PM +0300, Evgeniy Stepanov wrote:
> > > On Wednesday 08 November 2006 17:51, Diego Biurrun wrote:
> > > > On Wed, Nov 08, 2006 at 04:58:17PM +0300, Alexander Beregalov wrote:
> > > > > ./configure --enable-x264 --with-x264libdir=/usr/lib/
> > > > > does not add -lx264 to EXTRA_LIB (config.mak)
> > > >
> > > > Correct.  You are overriding autodetection.  And your patch breaks
> > > > autodetection.
> > > 
> > > That means you have to use --enable-x264 --with-extralibs="-lx264" ?
> > 
> > If you wish to override autodetection, then yes.  This is exactly the
> > meaning of the term "overriding autodetection".
> 
> This is utter nonsense. You should not need --with-extralibs to use
> the library that was requested with --enable!! --with-extralibs is
> just to add library paths or extra library dependencies that aren't
> detected.

Look around in configure.  As usual, there is no general agreement as to
what the tests should do or not do ...

In any case I have a hunch that the dependency on pthread is incorrect.
I don't use x264, though ...

Diego