[MPlayer-dev-eng] [PATCH] fix configure with --enable-x264

[Rich Felker]

On Wed, Nov 08, 2006 at 06:04:31PM +0100, Diego Biurrun wrote:
> On Wed, Nov 08, 2006 at 07:47:14PM +0300, Evgeniy Stepanov wrote:
> > On Wednesday 08 November 2006 17:51, Diego Biurrun wrote:
> > > On Wed, Nov 08, 2006 at 04:58:17PM +0300, Alexander Beregalov wrote:
> > > > ./configure --enable-x264 --with-x264libdir=/usr/lib/
> > > > does not add -lx264 to EXTRA_LIB (config.mak)
> > >
> > > Correct.  You are overriding autodetection.  And your patch breaks
> > > autodetection.
> > 
> > That means you have to use --enable-x264 --with-extralibs="-lx264" ?
> 
> If you wish to override autodetection, then yes.  This is exactly the
> meaning of the term "overriding autodetection".

This is utter nonsense. You should not need --with-extralibs to use
the library that was requested with --enable!! --with-extralibs is
just to add library paths or extra library dependencies that aren't
detected.

> > I find it a bit complicated. "-lx264" is not something that is autodetected, 
> > it should be added anytime x264 is used. Btw, xvid libs are automatically 
> > added with --enable-xvid.
> 
> The XviD check is broken then.  In fact I'm looking at it right now and
> it is also quite obfuscated and redundant..

No, your idea of what --enable should do it broken! Can you give ANY
good reason why the requested -l should be omitted???

Rich