[MPlayer-dev-eng] MSGTR for ao_alsa, aspect.c and vo_xv.c

[mail at kraymer.de]

> On Sun, Nov 05, 2006 at 11:19:11PM +0100, mail at kraymer.de wrote:
>>
>> --- libao2/ao_alsa.c	(revision 20722)
>> +++ libao2/ao_alsa.c	(working copy)
>> @@ -85,10 +86,10 @@
>>    tmp[sizeof tmp - 1] = '\0';
>>
>>    if (err)
>> -    mp_msg(MSGT_AO, MSGL_ERR, "alsa-lib: %s:%i:(%s) %s: %s\n",
>> +    mp_msg(MSGT_AO, MSGL_ERR, MSGTR_AO_ALSA_AlsaLibStrError,
>>  	   file, line, function, tmp, snd_strerror(err));
>>    else
>> -    mp_msg(MSGT_AO, MSGL_ERR, "alsa-lib: %s:%i:(%s) %s\n",
>> +    mp_msg(MSGT_AO, MSGL_ERR, MSGTR_AO_ALSA_AlsaLibError,
>>  	   file, line, function, tmp);
>
> IMO it does not make sense to move such messages.  They are hardly
> translatable..

I agree. But while this is true, it effectively removes hardcoded strings
from the source. I have no strong objection about leaving these two
unchanged though. (Btw I changed the string to "alsa-lib error: ..)IMO the translator has always the possibility to leave such a message out
or just copy it because the English text will end up in the binary anyway.