[MPlayer-dev-eng] [PATCH] trivial warning fix - loader/pe_image.c [NOVIRUS]

[Dominik 'Rathann' Mierzejewski]

On Friday, 05 May 2006 at 17:21, Rich Felker wrote:
> On Fri, May 05, 2006 at 11:18:54AM +0200, Pierre Lombard wrote:
> > Hi,
> > 
> > Some if- blocks are sometimes empty, which gcc warns of.
> > 
> > An unnecessary double return is also removed.
> > -- 
> > Pierre Lombard
> > GPG: 0x1AF0803C
> 
> > Index: pe_image.c
> > ===================================================================
> > RCS file: /cvsroot/mplayer/main/loader/pe_image.c,v
> > retrieving revision 1.10
> > diff -u -r1.10 pe_image.c
> > --- pe_image.c	25 May 2005 08:48:31 -0000	1.10
> > +++ pe_image.c	5 May 2006 08:51:47 -0000
> > @@ -107,8 +107,9 @@
> >                DPRINTF( "  %s", (char*)RVA(name[j]) );
> >                break;
> >            }
> > -	if ((*function >= rva_start) && (*function <= rva_end))
> > +	if ((*function >= rva_start) && (*function <= rva_end)) {
> >  	  DPRINTF(" (forwarded -> %s)", (char *)RVA(*function));
> > +	}
> 
> This is ugly.. The warning should just be disabled IMO

Agreed. Applied the double return removal, though.

> but I don't care about this file anyway.

:)

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan