[MPlayer-dev-eng] [PATCH] trivial warning fix - loader/pe_image.c [NOVIRUS]

joerg at britannica.bec.de joerg at britannica.bec.de
Sat May 13 20:48:26 CEST 2006


On Fri, May 05, 2006 at 11:21:58AM -0400, Rich Felker wrote:
> > Index: pe_image.c
> > ===================================================================
> > RCS file: /cvsroot/mplayer/main/loader/pe_image.c,v
> > retrieving revision 1.10
> > diff -u -r1.10 pe_image.c
> > --- pe_image.c	25 May 2005 08:48:31 -0000	1.10
> > +++ pe_image.c	5 May 2006 08:51:47 -0000
> > @@ -107,8 +107,9 @@
> >                DPRINTF( "  %s", (char*)RVA(name[j]) );
> >                break;
> >            }
> > -	if ((*function >= rva_start) && (*function <= rva_end))
> > +	if ((*function >= rva_start) && (*function <= rva_end)) {
> >  	  DPRINTF(" (forwarded -> %s)", (char *)RVA(*function));
> > +	}
> 
> This is ugly.. The warning should just be disabled IMO but I don't
> care about this file anyway.

What about ensuring that dbg_printf is a valid (empty) statment instead?
Something like (void)0 or do {} while(0)

Joerg




More information about the MPlayer-dev-eng mailing list