[MPlayer-dev-eng] [PATCH] configure fixes for pkg-config invocation

Diego Biurrun diego at biurrun.de
Mon Mar 20 11:55:35 CET 2006


On Sun, Mar 19, 2006 at 09:47:25AM +0100, Emanuele Giaquinta wrote:
> On 3/19/06, Diego Biurrun <diego at biurrun.de> wrote:
> 
> > Why do you add --silence-errors sometimes but not always, why do you
> > remove the > /dev/null 2>&1 redirection in places?
> 
> "pkg-config --exists $PKG" exits with status 0 or 1 returning no
> output. The invocation in the fontconfig cc test is different; I added
> --silence-errors because there is no check before for the existence of
> fontconfig in the pkg-config db (like the jack and theora tests).

This sounds like those invocations should be further simplified to just
use "--exists" instead of "--silence-errors --cflags --libs" as well
then.

Anyway, patch applied, the separate issue can be addressed later.

Diego




More information about the MPlayer-dev-eng mailing list