[MPlayer-dev-eng] last printf in libaf

[Corey Hickey]

On Tue, March 14, 2006 16:58, Reynaldo H. Verdejo Pinochet wrote:
>> > Hope is ok to commit, is the last one on libaf
>>
>> [cut]
>>
>> > +// af_format.c
>> > +
>> > +#define MSGTR_AF_FORMAT_UnknownSpecial "Unknown special\n"
>>
>> My first thought was, "what does that mean?" I took a look at the code,
>> and thought saying "unknown format" or maybe "unknown special format"
>> would be better.
>>
>> Then, I saw that it's in af_fmt2str(), which looks like it converts a
>> numeric format into a string for human consumption. Wouldn't it be
>> better to use snprintf() to put that message into the string so it gets
>> printed in the proper context?
>>
>> I would prefer the attached patch.
>
> Hi Corey, I didnt get to read this message before commiting :/ there
> where problems with the ml. I agree, at least the message needs to be
> rethinkered/rewrited, could you please take care of the modification?

No problem. How's this? If all is well I'll commit it tomorrow.

-Corey
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: unknown-format.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060314/a0b7cd6d/attachment.asc>