[MPlayer-dev-eng] [PATCH] Returned without freeing storage "cddb_info"

[Reimar Döffinger]

Hi,
On Sun, Mar 12, 2006 at 03:24:25PM +0100, Guillaume POIRIER wrote:
> The attached patch addresses the following resource leak detected by
> Covertity's checker:
> 
> CID: 154
> Checker: RESOURCE_LEAK (help)
> File: main/libmpdemux/cdda.c
> Function: open_cdda
> Description: Returned without freeing storage "cddb_info"
> 
> Do you think it's okay?

I think so, though I prefer the "goto fail" approach as it helps
to avoid making the same error again when e.g. adding a new abort
condition

Greetings,
Reimar Döffinger