[MPlayer-dev-eng] [PATCH] ggi osd support added

[Hervé W.]

On 30/06/06, Rich Felker <dalias at aerifal.cx> wrote:
> > > mplayer -vf expand=::::1
> > >
> >
> > Would it make sense to make this a default for drivers that do no
> > implement the osd?  I think there are a lot of people who do not know
> > about this option.
>
> No, auto-loading filters to second-guess the user is lame and it will
> also result in bad performance. The vo drivers should be fixed to
> support osd if they don't.
>
> OSD should be added, but the code you submitted is just incorrect and
> will cause all kinds of corruption. A working patch would be very
> welcome I'm sure.

Perhaps in the meantime some feedback could be provided to the user?
Something like:
"The selected video output driver doesn't support On Screen Display
(OSD) messages. If you'd like OSD to be enabled, select a different
video output driver or add -vf-add expand=::::1 to the startup
command. WARNING: adding video filters, like expand, may decrease
playback performance."

-V