[MPlayer-dev-eng] [PATCH] ggi osd support added

[Rich Felker]

On Fri, Jun 30, 2006 at 02:39:59PM -0400, spdepagn at ncsu.edu wrote:
> Hi, thanks for all the feedback.
> 
> > 2006/6/30, spdepagn at ncsu.edu <spdepagn at ncsu.edu>:
> >> Hi, I have added support for the osd to the ggi output driver.  I am
> >> wondering why the osd is implemented so each output driver must
> >> implement
> >> it.
> >
> > It must not.
> >
> > mplayer -vf expand=::::1
> >
> 
> Would it make sense to make this a default for drivers that do no
> implement the osd?  I think there are a lot of people who do not know
> about this option.

No, auto-loading filters to second-guess the user is lame and it will
also result in bad performance. The vo drivers should be fixed to
support osd if they don't.

> > You are storing osd internal planes from previous frame and draw them
> > on the next one, in draw_slice().
> >
> > draw_slice() could be called many times for sinlge picture when new
> > slice (16 lines) have been updated. You are currently redrawing all
> > osd elements on every slice.
> >
> > I must check the source in order to be sure that these planes are not
> > freed after they've been "drawn". Causing your driver to access freed
> > memory.
> >
> > Messing with osd internals looks quite horrible way to implement osd.
> > And I don't think it could be accepted.
> >
> > Rejected.
> > _______________________________________________
> 
> I understand your reasons for rejecting this, especially since the osd can
> be added with another option.  Thanks

OSD should be added, but the code you submitted is just incorrect and
will cause all kinds of corruption. A working patch would be very
welcome I'm sure.

Rich