[MPlayer-dev-eng] [PATCH] vd_sgi bugfix on AMD64

[Reynaldo H. Verdejo Pinochet]

On Thu, Jun 29, 2006 at 11:13:12PM +0200, Reimar Döffinger wrote:
> Hi,
> On Thu, Jun 29, 2006 at 08:25:15PM +0200, Paul-Francois Fontigny wrote:
> > SGI compressed images don't show up correctly on AMD64.
> > The attached patch solve it.
> 
> No objections to this patch, but...
> 
> > -  unsigned long *starttab;
> > +  uint32_t *starttab;
> [...]
> > -  starttab = (long*)(data + SGI_HEADER_LEN); 
> > +  starttab = (uint32_t*)(data + SGI_HEADER_LEN); 
> [...]
> > -      start_offset = be2me_32(*(unsigned long*) &starttab[y + z * ysize]);
> > +      start_offset = be2me_32(*(uint32_t*) &starttab[y + z * ysize]);
> 
> Did someone take a course in "how many useless typecast fit in one C
> program" or do I miss something??

yeah, maybe he thinked it would be considered a cosmethic change :)

	Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060629/c6f00ec2/attachment.pgp>