[MPlayer-dev-eng] [PATCH] vd_sgi bugfix on AMD64

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Jun 29 23:13:12 CEST 2006


Hi,
On Thu, Jun 29, 2006 at 08:25:15PM +0200, Paul-Francois Fontigny wrote:
> SGI compressed images don't show up correctly on AMD64.
> The attached patch solve it.

No objections to this patch, but...

> -  unsigned long *starttab;
> +  uint32_t *starttab;
[...]
> -  starttab = (long*)(data + SGI_HEADER_LEN); 
> +  starttab = (uint32_t*)(data + SGI_HEADER_LEN); 
[...]
> -      start_offset = be2me_32(*(unsigned long*) &starttab[y + z * ysize]);
> +      start_offset = be2me_32(*(uint32_t*) &starttab[y + z * ysize]);

Did someone take a course in "how many useless typecast fit in one C
program" or do I miss something??

Greetings,
Reimar Doeffinger



More information about the MPlayer-dev-eng mailing list