[MPlayer-dev-eng] Re: [PATCH] SSA/ASS subtitles support

[Uoti Urpala]

On Sun, 2006-06-18 at 22:35 +0400, Evgeniy Stepanov wrote:
> > If you're going to keep working on the files and strongly prefer 8
> > spaces I don't have major objections against that (I don't find the
> > files hard to read), but would prefer a 4-space indent.
> 
> These files have 1 tab indentation, not 8 spaces. Why don't you set tab size 
> to 4 ? Yes, I'm going to maintain them for some time.

The problem is not so much the particular amount of indentation but the
fact that all the files use different settings and styles, and often
after a while when several people have worked on the files there are
different styles within a file too. Setting the editor to use
nonstandard tab sizes for some files would only make it worse. Anyway if
you want to use tabs I won't insist on it.

> > I think it would be nice to print a diagnostic (at least at verbose
> > level, maybe higher) if some parts are skipped because of parsing
> > errors, especially as not quite all features are yet supported. I had

> {} quite often is used for comments. Printing them at verbose level may be ok, 
> but not higher.

Maybe {}, but what about after '\'?