[MPlayer-dev-eng] Re: [PATCH] SSA/ASS subtitles support

[Evgeniy Stepanov]

On Sunday 18 June 2006 22:01, Uoti Urpala wrote:
> I think the patch could be applied soon and further fixes done in svn.
> One thing I'd personally like to change before applying it is the
> indentation style of new files. MPlayer has traditionally added new
> files using whatever indentation style the author preferred, but as
> maintainers of files change over time and other people usually have to
> at least read the files I don't particularly like the end result. My
> idea of the most agreeable common style is basically that produced by
> "indent -kr", with the only significant difference from the current
> files being an indentation level of 4 spaces instead of the current 8.
> If you're going to keep working on the files and strongly prefer 8
> spaces I don't have major objections against that (I don't find the
> files hard to read), but would prefer a 4-space indent.

These files have 1 tab indentation, not 8 spaces. Why don't you set tab size 
to 4 ? Yes, I'm going to maintain them for some time.

> +#define skip(x) if (*p == (x)) ++p; else { return p; }
>
> I think it would be nice to print a diagnostic (at least at verbose
> level, maybe higher) if some parts are skipped because of parsing
> errors, especially as not quite all features are yet supported. I had
> some subtitles using the 6-argument version of \move which became
> completely invisible due to clipping when the move was ignored, now
> there was no indication that anything might be missing.

{} quite often is used for comments. Printing them at verbose level may be ok, 
but not higher.