[MPlayer-dev-eng] [PATCH] Remove duplicated CPU detection in libmpeg2

[Guillaume POIRIER]

Hi,

On 6/15/06, jserv at linux2.cc.ntu.edu.tw <jserv at linux2.cc.ntu.edu.tw> wrote:
> On Thu, Jun 15, 2006 at 05:08:30PM +0200, Michael Niedermayer wrote:
> > and its still not correct for MMX2 + 3dnow cpus, or SSE2 + 3dnow
> > and the code is getting more and more messy for a trivial
> >
> > if(mmx)   flags |= MMX;
> > if(3dnow) flags |= 3DNOW;
> > ...
> > return flags
> >
> > and please no 20 #ifdefs around each if()
>
> hi Michael,
>
>   Thanks for pointing me of the issue. However, I think the detection
> should be trivial since there are few corresponding accelerated
> implementations for idct and motion compensation in libmpeg2.

It's always better do do things right the first time if possible. If
there aren't corresponding implementation, that doesn't there will
never be! ;)


> Ought to enumeration all possibility or not, I am wondering, and I
> appreciate the discussion in MPlayer mailing-list.

Except that Michael's suggestions aren't open for discussion, as he's
the boss! ;-)

Guillaume
-- 
"Success consists of going from failure to failure without loss of enthusiasm."
 -- Winston Churchill